-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancel #463
Fix cancel #463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the travis test failures is an actual issue. I'll look into it.
@anyaelena -- actually is there a way you can fix the test? |
@nllong yes, i'll look into it. |
@anyaelena thanks. I think this can be merged down once you fix the failing test. |
@nllong i verified locally that complete is working as expected. i don't have the test working but my working theory is that the introduction of the after_enqueue hook is messing with the test setup. |
@anyaelena - i fixed the test to have it check for something else to ensure completion. I'm pretty sure that the queue is not getting updated because the simulations are not actually running in a queue so any triggers are probably ignored. (https://github.com/NREL/OpenStudio-server/pull/463/files#diff-0a351848e90287c4b763ccbc56e78ea3R143). |
Fixes #437