set up CI to work w/pre-release OpenStudio packages by adding OPENSTUDIO_VERSION_EXT. #473
Conversation
|
we are going to wait until after 2.8.0 to tackle pre-release extensions. for now, tim will also publish a duplicate package in the legacy format (ie $VERSION.$SHA instead of $VERSION$EXT.$SHA) |
|
@anyaelena - can you resolve these conflicts and I will review this. |
|
ok @nllong this is also ready for review publishing of OSS docker images and amis w/version extension should just work from master branch, assuming VERSION_EXT is set in server/lib/version.rb. |
|
actually @nllong hold off a little longer. i'm looking at moving our version/sha/ext config into a single yml file that can be referenced in travis, appveyor, and Dockerfile |
| @@ -56,13 +56,14 @@ jobs: | |||
| - BUILD_TYPE=docker | |||
| before_script: | |||
| # remove the .git in the .dockerignore so coverage can be reported correctly to coveralls | |||
| - export OPENSTUDIO_TAG=$(ruby -e "load 'server/app/lib/openstudio_server/version.rb'; print OpenstudioServer::VERSION+OpenstudioServer::VERSION_EXT") | |||
|
|
||
| ARG OPENSTUDIO_VERSION=2.8.0 | ||
| #may include suffix | ||
| ARG OPENSTUDIO_VERSION |
There was a problem hiding this comment.
looks like this is now going to be a required input... that is if the user does not specify the input then this won't build.
| VERSION_EXT = ''.freeze # with preceding - or + | ||
| OS_SHA = '55665635f0' |
There was a problem hiding this comment.
will this need to be specified every version change?
…ver include version suffix.
…to a var at top of file)
|
closes #474 |
NOTE: adding separate issue/PR to allow Dockerfile to build off of pre-release OpenStudio Docker images. Changes to Dockerfile are not appropriate at this stage in the 2.8.0 release.