Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make downloading files back to server optional #571

Merged
merged 1 commit into from
Jun 22, 2020
Merged

make downloading files back to server optional #571

merged 1 commit into from
Jun 22, 2020

Conversation

brianlball
Copy link
Contributor

Issue #570

The defaults are to still download results.
The user can override.

@brianlball brianlball mentioned this pull request Jun 20, 2020
Closed
@brianlball brianlball requested a review from nllong June 20, 2020 01:19
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 66.896% when pulling 6f5ac87 on zip_download into f1b8acb on develop.

@brianlball brianlball mentioned this pull request Jun 20, 2020
Closed
@brianlball brianlball merged commit 8b81c04 into develop Jun 22, 2020
@brianlball brianlball deleted the zip_download branch June 22, 2020 15:18
@nllong
Copy link
Member

nllong commented Jun 22, 2020

changes look good! thanks for implementing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brianlball @coveralls @nllong