Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mongo and redis #613

Merged
merged 18 commits into from
Dec 28, 2020
Merged

Update mongo and redis #613

merged 18 commits into from
Dec 28, 2020

Conversation

tijcolem
Copy link
Contributor

@tijcolem tijcolem commented Dec 22, 2020

Updates mongo and redis to use the latest supported versions. Sets a user-defined password for Mongo and Redis.

Current server mongo::3.4.10
Latest mongo: 4.4.2

Current server redis: 4.0.6
Latest redis: 6.09

This should get updated as well: NREL/OpenStudio-PAT#173

@tijcolem tijcolem requested a review from nllong December 23, 2020 00:03
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look great! If the tests pass then we should be good.

I tested locally with docker-compose and PAT3.1. Old db volumes will need to be deleted, but I think that is a given and not an issue due to the ephemeral running of the server.

@nllong
Copy link
Member

nllong commented Dec 23, 2020

@tijcolem Can you add a note in the CHANGELOG on what has been updated? Thanks! 🤘

@tijcolem
Copy link
Contributor Author

Thanks, @nllong I added notes to CHANGELOG. All up-to-date.

@nllong
Copy link
Member

nllong commented Dec 28, 2020

@tijcolem -- do we need to migrate to travis-ci.com? Or do we have adequate testing with Jenkins across the platforms?

https://travis-ci.org/github/NREL/OpenStudio-server/builds/751822545

Also, the failure looks like failed resolution to some gems. That may resolve itself...

@tijcolem
Copy link
Contributor Author

@nllong Yeah, we have some Travis changes ahead. As you pointed out, they are decommissioning https://travis-ci.org/. (no cutoff date posted). Once we are on travis-ci.com, they also will begin charging for MacOs builds using a credit system. You can read more here:
https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

My understanding is once we are moved off https://travis-ci.org these changes will take effect, so we'll need to plan now. I'll look into this more and find out options.

@tijcolem
Copy link
Contributor Author

And oh, I actually canceled the Travis runs as this was just a document update.

@nllong
Copy link
Member

nllong commented Dec 28, 2020

Gotcha, thanks for the update on Travis. On other projects we have been moving over to github actions and it has been nice. I've yet to setup mac builds on github actions... maybe that is an option?

@tijcolem
Copy link
Contributor Author

GitHub actions is great. I've used that for some jobs on OpenStudio. The only potential concern is the lack of disk space - 14 GB which may be an issue for our integration runs. https://docs.github.com/en/free-pro-team@latest/actions/reference/specifications-for-github-hosted-runners

@tijcolem tijcolem merged commit 8680602 into develop Dec 28, 2020
@tijcolem tijcolem deleted the update_mongo_and_redis branch December 28, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants