Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap ZoneHVAC:RefrigerationChillerSet #4921

Closed
eringold opened this issue Jun 28, 2023 · 4 comments
Closed

Wrap ZoneHVAC:RefrigerationChillerSet #4921

eringold opened this issue Jun 28, 2023 · 4 comments

Comments

@eringold
Copy link
Contributor

eringold commented Jun 28, 2023

Enhancement Request

OpenStudio already wraps Refrigeration:AirChiller, but it is not much use without the zone equipment to reference it. ZoneHVAC:RefrigerationChillerSet is needed to model refrigerated warehouses.

https://bigladdersoftware.com/epx/docs/23-1/input-output-reference/group-zone-forced-air-units.html#zonehvacrefrigerationchillerset

https://github.com/NREL/EnergyPlus/blob/develop/testfiles/RefrigeratedWarehouse.idf

@eringold eringold added Enhancement Request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jun 28, 2023
@jmarrec
Copy link
Collaborator

jmarrec commented Jul 4, 2023

RefrigerationAirChiller is used on the RefrigerationSystem and RefrigerationSecondarySystem https://bigladdersoftware.com/epx/docs/23-1/input-output-reference/group-refrigeration.html#field-refrigerated-case-or-walkin-or-caseandwalkinlist-name and can apparently be used without this object.

Just saying, not saying ZoneHVAC:RefrigerationChillerSet does not fit a purpose and shouldn't be wrapped.

It seems to be a rather simple object. I don't like the E+ IDD though. Seems that it should be a proper ZoneHVAC component, defining the Inlet / outlet nodes, and being part of the ZoneHVACEquipment etc, but apparently it's more of a space load...

-  A3  , \field Zone Name
        \note This must be a controlled zone and appear in a ZoneHVAC:EquipmentConnections object.
        \type object-list
        \object-list ZoneNames
  A4 ,  \field Air Inlet Node Name
        \type node
-        \note Not used - reserved for future use
        \note Name of the zone exhaust node (see Node) from which the refrigeration chiller
        \note draws its indoor air.
        \note This should be one of the zone exhaust nodes for the zone cooled by the chiller set.
  A5 ,  \field Air Outlet Node Name
        \type node
-        \note Not used - reserved for future use
        \note The name of the node where the chiller coil sends its outlet air,
        \note which must be one of the inlet air nodes for the zone which is being cooled.

jmarrec added a commit that referenced this issue Jul 4, 2023
… (will be able to get it from ZoneHVAComponent if listed on the ZoneHVACEquipmentList)
@jmarrec
Copy link
Collaborator

jmarrec commented Jul 5, 2023

I wish this was documented a bit better, but this is actually already handled. Just do RefrigerationAirChiller::addToThermalZone (in the order you need it), and the FT takes care of it

IdfObject _chillerSet(IddObjectType::ZoneHVAC_RefrigerationChillerSet);
m_idfObjects.push_back(_chillerSet);
_chillerSet.setName(name + " Refrigeration Chiller Set");

@jmarrec jmarrec closed this as completed Jul 5, 2023
jmarrec added a commit that referenced this issue Jul 5, 2023
@jmarrec
Copy link
Collaborator

jmarrec commented Jul 5, 2023

Added a docstring explaining this in 2af6123 , this will show on the SDK documentation

@jmarrec jmarrec self-assigned this Jul 5, 2023
@jmarrec jmarrec added resolution - Works As Expected component - Model and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Jul 5, 2023
@eringold
Copy link
Contributor Author

eringold commented Jul 7, 2023

thanks @jmarrec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants