-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is OpenStudio.dll no longer included in the installers? #4931
Comments
@chriswmackey I think you may be reporting the same issue as
Is this what you are reporting? (Basically I'm asking if you can try with the C++ API component selected). If so, can close this issue, fixed in: |
Thanks @jmarrec , I believe that my issue is different because I see the My issue is that this is what I get with the OpenStudio NuGet package: But this is what I get from the OpenStudio installer released here through GitHub whenever I check the boxes for all of the options. Here's the Neither of those folders has the |
Got it. Thanks. I do see OpenStudio.dll being built correctly on CI. But indeed it's not installed. 99% sure this is due to the OpenStudio/csharp/CMakeLists.txt Line 68 in 82304dc
|
Actually I'm pretty sure I see why that has happened. This is a left over from refactoring: 84f36ac#diff-eb198a8407cb15ec84351a8a476aa8b60112377c0b12be331baa2874ea20c786L79 |
Ops, I thought there was a post-process to copy all files into the installer folder. I didn't realize this CMakeLists also creates the installer. @jmarrec thanks for helping. |
CONFIGURATION genex is deprecated since cmake 3.0 and replaced with CONFIG
I'm fixing it right now @MingboPeng |
Thanks! |
I replaced the CMAKE_BUILD_TYPE with a genex too. This was working on CI because we do pass explicitly |
Thanks for getting to the bottom of this, @jmarrec and @MingboPeng . I'm looking forward to having this back in the next installer release. |
CONFIGURATION genex is deprecated since cmake 3.0 and replaced with CONFIG
Fix #4931 - Install C# OpenStudio.dll properly.
Enhancement Request
I'm opening this as an enhancement request but it may be more of a question and I just have not found the right answer yet. Starting from OpenStudio 3.5, it seems that there is no longer an
OpenStudio.dll
included in the Windows exe installer and the only way that I have currently found to obtain this .dll is from the OpenStudio NuGet package.This seemed odd to me because all of the other csharp dlls are in the installer but I am missing the critical one that I need in order to be able to make use of the CSharp bindings.
So I first wanted to ask if this is the intended setup and I am just not understanding how I am now supposed to be making use of the CSharp bindings (eg. should I be adding a different one of these dlls instead of the
OpenStudio.dll
that I have historically used?) If it is the intended setup, could you instruct me on which dll should be added to enable me to import OpenStudio SDK in .NET. Or do I need to add all of them?If this is not the intended setup, it would be really nice if future OpenStudio installers could put back the
OpenStudio.dll
somewhere in the installation folder. I have verified that the latest OpenStudio 3.6.1 installer also lacks theOpenStudio.dll
Thanks, as always.
CC: @jmarrec , @MingboPeng
The text was updated successfully, but these errors were encountered: