Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate reducing the number of JSON files being written during workflow (measure_attributes.json, results.json, data_point_out_.json) #5029

Open
jmarrec opened this issue Nov 13, 2023 · 0 comments
Open

Investigate reducing the number of JSON files being written during workflow (measure_attributes.json, results.json, data_point_out_.json) #5029

jmarrec opened this issue Nov 13, 2023 · 0 comments
Assignees
@brianlball
Labels
component - CLI component - logs and warnings component - Workflow Enhancement Request

Comments

@jmarrec
Copy link
Collaborator

jmarrec commented Nov 13, 2023 •
edited
Loading

Enhancement Request

Context: #5028 (review)

When things calm down, it'd be good to investigate this.

Detailed Description

  • We get the same info in measure_attributes.json, results.json and data_point_out.json...
  • measure_attributes.json is flushed after each apply measure Step (ModelMeasures, EnergyPlusMeasures,
    ReportingMeasures), then at the end of ReportingMeasures it's done once again and results.json is spat out too
  • Do we really need the data_point_out.json in addition to this?
  • Seems like we could just run the output of results.json/data_point_out.json at the end of the workflow run instead

Possible Implementation

Standardize on a single file.
jmarrec added a commit that referenced this issue Nov 13, 2023
@jmarrec
Add data_point_out.json as requested
5193679 
I talked to some folks who suggested just adding it, and I filed #5029 for investigating at a later date if we can just use a single file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianlball brianlball

Labels
component - CLI component - logs and warnings component - Workflow Enhancement Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brianlball @DavidGoldwasser @jmarrec