Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master master + Bump to 3.6.1-alpha and add default VT #4880

Merged
merged 24 commits into from
May 10, 2023
Merged

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 10, 2023

Pull request overview

Master master + Bump to 3.6.1-alpha and add default VT

@jmarrec jmarrec added Developer Issue Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels May 10, 2023
@jmarrec jmarrec requested a review from tijcolem May 10, 2023 08:52
@jmarrec jmarrec self-assigned this May 10, 2023
Comment on lines +213 to +214
if [ "$RUNNER_OS" == "Linux" ]; then
cmake --build . --target package -j 1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tijcolem I noticed this. Did that solve the gcc crashing?

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 10, 2023

All clear. I'm going to merge this @tijcolem since currently most PRs are having a CPack issue due to trying to install release notes that don't exist except on master.

@jmarrec jmarrec merged commit 5025a1a into develop May 10, 2023
@jmarrec jmarrec deleted the bump_361 branch May 10, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Developer Issue IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants