Fix #4882 - Avoid a crash in createFluidProperties during FT that's due to Undefined Behavior #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
added
severity - Normal Bug
component - IDF Translation
Pull Request - Ready for CI
jmarrec
commented
May 10, 2023
Comment on lines
+174
to
+189
| TEST_F(EnergyPlusFixture, ForwardTranslator_PlantLoop_createFluidProperties) { | ||
| // test for #4482 - It crashes with 5 plantloops | ||
|
|
||
| for (int n = 1; n <= 10; ++n) { | ||
| Model m; | ||
|
|
||
| for (int i = 0; i < n; ++i) { | ||
| PlantLoop p(m); | ||
| EXPECT_TRUE(p.setFluidType("PropyleneGlycol")); | ||
| EXPECT_TRUE(p.setGlycolConcentration(50 + i)); | ||
| } | ||
| ForwardTranslator ft; | ||
| // EXPECT_TRUE(false) << "Failed for " << n << " PlantLoops"; | ||
| ASSERT_NO_THROW(ft.translateModel(m)) << "Failed for " << n << " PlantLoops"; | ||
| } | ||
| } |
There was a problem hiding this comment.
Before fix it crashes at 5 PlantLoops
[ RUN ] EnergyPlusFixture.ForwardTranslator_PlantLoop_createFluidProperties
/Users/julien/Software/Others/OpenStudio/src/energyplus/Test/PlantLoop_GTest.cpp:186: Failure
Value of: false
Actual: false
Expected: true
Failed for 1 PlantLoops
/Users/julien/Software/Others/OpenStudio/src/energyplus/Test/PlantLoop_GTest.cpp:186: Failure
Value of: false
Actual: false
Expected: true
Failed for 2 PlantLoops
/Users/julien/Software/Others/OpenStudio/src/energyplus/Test/PlantLoop_GTest.cpp:186: Failure
Value of: false
Actual: false
Expected: true
Failed for 3 PlantLoops
/Users/julien/Software/Others/OpenStudio/src/energyplus/Test/PlantLoop_GTest.cpp:186: Failure
Value of: false
Actual: false
Expected: true
Failed for 4 PlantLoops
/Users/julien/Software/Others/OpenStudio/src/energyplus/Test/PlantLoop_GTest.cpp:186: Failure
Value of: false
Actual: false
Expected: true
Failed for 5 PlantLoops
[BOOST_ASSERT] <2> Assertion m_impl failed on line 2031 of openstudio::IdfObject::IdfObject(const openstudio::IdfObject &) in file /Users/julien/Software/Others/OpenStudio/src/utilities/idf/IdfObject.cpp.
Assertion failed: (false), function assertion_failed, file Assert.hpp, line 61.
0% tests passed, 1 tests failed out of 1
Total Test time (real) = 0.49 sec
The following tests FAILED:
2890 - EnergyPlusFixture.ForwardTranslator_PlantLoop_createFluidProperties (Subprocess aborted)
Comment on lines
+4514
to
+4519
| // NOTE: do not do another emplace_back before returning | ||
| IdfObject& fluidPropName = m_idfObjects.emplace_back(openstudio::IddObjectType::FluidProperties_Name); | ||
| fluidPropName.setString(FluidProperties_NameFields::FluidName, glycolName); | ||
| fluidPropName.setString(FluidProperties_NameFields::FluidType, "Glycol"); | ||
|
|
||
| return {fluidPropName}; |
|
CI Results for 7386ea9:
|
|
I tested the Ubuntu 22.04 installer locally on WSL2, and it seems to correct the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test)src/energyplus/Test)src/osversion/VersionTranslator.cpp)Labels:
IDDChangeAPIChangePull Request - Ready for CIso that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.