Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AirLoopHVACUnitarySystem set Method During XXX Operation - option, 2 #4927

Merged
merged 2 commits into from
Jul 13, 2023
Merged

AirLoopHVACUnitarySystem set Method During XXX Operation - option, 2 #4927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
08858b4
Add None default to idd.
joseph-robertson Jul 12, 2023
fa7543a
Simplify method getter after introducing None default.
joseph-robertson Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions resources/model/OpenStudio.idd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11902,6 +11902,7 @@ OS:AirLoopHVAC:UnitarySystem,
\key FlowPerFloorArea
\key FractionOfAutosizedCoolingValue
\key FlowPerCoolingCapacity
\default None
\note Enter the method used to determine the cooling supply air volume flow rate.
\note None is used when a cooling coil is not included in the unitary system or this field may be blank.
\note SupplyAirFlowRate is selected when the magnitude of the supply air volume is used.
Expand Down
10 changes: 3 additions & 7 deletions src/model/AirLoopHVACUnitarySystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,13 +370,9 @@ namespace model {
}

std::string AirLoopHVACUnitarySystem_Impl::supplyAirFlowRateMethodDuringCoolingOperation() const {
// No default, and return uninitialized if empty
boost::optional<std::string> result_ =
getString(OS_AirLoopHVAC_UnitarySystemFields::SupplyAirFlowRateMethodDuringCoolingOperation, false, true);
if (result_) {
return *result_;
}
return "None";
boost::optional<std::string> value = getString(OS_AirLoopHVAC_UnitarySystemFields::SupplyAirFlowRateMethodDuringCoolingOperation, true);
OS_ASSERT(value);
return value.get();
}

boost::optional<double> AirLoopHVACUnitarySystem_Impl::supplyAirFlowRateDuringCoolingOperation() const {
Expand Down