Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sim.py #196

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Update sim.py #196

merged 1 commit into from
Dec 19, 2022

Conversation

aclerc
Copy link
Contributor

@aclerc aclerc commented Dec 15, 2022

Fix gen_power in sim_ws_wd_series so it includes efficiency

Description and Purpose

I noticed a similar issue was recently fixed in sim_ws_series in #167 it seems sim_ws_wd_series needs the same fix

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

TODO Items General:

  • Add example/test for new feature
  • Update registry
  • Run testing

TODO Items API Change:

  • Update docs with API change
  • Run update_rosco_discons.py in Test_Cases/
  • Update DISCON schema

Github issues addressed, if one exists

Examples/Testing, if applicable

Fix gen_power in sim_ws_wd_series so it includes efficiency
@dzalkind
Copy link
Collaborator

Thank you for making this fix!

@dzalkind dzalkind merged commit 827b281 into NREL:develop Dec 19, 2022
@aclerc aclerc deleted the develop branch December 19, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants