Add various features and tests to ZeroMQ wind farm control implementation #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzalkind
reviewed
Nov 30, 2023
ROSCO_toolbox/control_interface.py
Outdated
|
|
||
| logger = logging.getLogger(__name__) | ||
| logger.setLevel(logging.INFO) | ||
| # logger.setLevel(logging.DEBUG) |
There was a problem hiding this comment.
Is this still needed? I'm not that familiar with logging.
There was a problem hiding this comment.
Users can choose either line 32 for a basic log or line 33 for a more detailed log.
Maybe I can add a comment here explaining this.
abhineet-gupta
commented
Nov 30, 2023
| logger = logging.getLogger(__name__) | ||
| # Choose logging level below | ||
| logger.setLevel(logging.INFO) # For a basic level of logs | ||
| # logger.setLevel(logging.DEBUG) # For more detailed logs helpful for debugging |
There was a problem hiding this comment.
Added comments here
dzalkind
added a commit
that referenced
this pull request
Dec 15, 2023
* Add script for auto-generating zmq interface * Add torque offset because we needed to fill the setpoint slot * Add a working example to help further development of ZMQ for farm control * Use setpoints/measurements on python side * Complete merge with ZMQ_Indentifier * Standardize setpoints on zmq server side, now attr of class * Rename zeromq examples * Set up multi_openfast example with run_FAST routines * Add ZMQ_* inputs to schema, input writer * Set relative path to wfc_interface file * Rename ZMQ_Identifier to ZMQ_ID * Rename turbine_zmq_server and make setpoints/measurements a list * Try apt-get update * Rename zmq examples in test script * Modify ZeroMQ wind farm control interface and example to more object oriented code * Fix update period logic for ZMQ client * Update DISCONs * Cast ZMQ_ID as int * Add various features and tests to ZeroMQ wind farm control implementation (#282) * Add tests to example-17b * Add logging to zmq server for wind farm control * Small changes to zeromq interface to make the code more descriptive and robust * Modify example-17a to work with new zeromq wind farm control interface and some minor changes * Add helpful comment about logging level --------- Co-authored-by: AbhineetGupta <abhineet.gupta@nrel.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add various features and tests to ZeroMQ implementation.
Wind farm control interface modified to spawn a single server which connects to multiple ROSCO clients. Examples added/modified to demonstrate the capability.
Type of change
Examples/Testing, if applicable
Example 17a modified to reflect the new zeromq framework
Example 17b demonstrates wind farm control with zeromq framework
Both tests pass locally on a mac