-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ETS heat pump COP from GMT sys-params #32
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it would be good to add a test here. I merged in multi-ghe
locally and ran tests, and they all passed. I think once we have a test for the changes in this branch, I'm good.
Ahh, right. I have the json file to show the changes, but I never actually made an assertion for it. I'll make that happen. Thanks Matt! |
Any background context you want to provide?
We were unintentionally not allowing users to change ETS heat-pump COP values. That is now available
What does this PR accomplish?
cop_c
andcop_h
values from a sys-param fileHow should this be manually tested?
final ets_data:
forcop_c
andcop_h
.What are the relevant tickets?
Screenshots (if appropriate)