Feature/update reqs pin polars #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
I've cloned this, installed it, and run the artificial data examples without any issues so I think you're good to go here.
Note that this is PR is currently pointing to merge into NREL:main, which I think is what you intended because it's a bug fix, but just checking
Thanks @misi9170 ! That's right, plan was to merge into main and then back merge this change to develop, I'll do it now... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be merged
Feature or improvement description
This pull request implements two small changes to the requirements:
Except for polars, requirements specified via ~=1.1, which is interpreted as >=1.1, ==1.*, which essentially means latest minor version which matches major version, and is >= minor version specified. Can see:
https://packaging.python.org/en/latest/specifications/version-specifiers/#id4
Related issue, if one exists
Closes #139
Issue #133
Impacted areas of the software
setup.py