Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/detect yaw shift #148

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Dec 14, 2023

This is not ready to merge, just wanted to share the main concept

Feature or improvement description
The pr adds a new file turbine_analysis/detect_yaw_change.py based on approaches suggested by @ejsimley which implements a method for detecting sudden shifts in the northing calibration of yaw angle. The approach is based on cusum change detection one example here. The pr addresses Issue #106

Note this is built on the ruff branch/pr (PR #143 ) so appears to have many more file changes then it actually does. Once that is merged to develop.

Still some way to go on this but main ideas of next steps:

  • Do @ejsimley , @misi9170 , @Bartdoekemeijer like the approach?
  • Should we add cleverness about looping several times for multiple shifts or lean on repeated calls?
  • Should we look to correct wd with yaw?
  • Should I convert to polars for speed? Lots of memory stuff, copying etc,
  • I think the circular median would do a better job than the mean, but this is hard to find existing and not straightforward to implement
  • Add tests
  • Add examples

Related issue, if one exists
Closes #106

Impacted areas of the software
turbine_analysis/detect_yaw_change.py

@paulf81 paulf81 changed the base branch from develop to v2 January 31, 2024 23:35
@misi9170 misi9170 deleted the branch NREL:develop July 23, 2024 18:06
@misi9170 misi9170 closed this Jul 23, 2024
@misi9170 misi9170 reopened this Jul 25, 2024
@misi9170 misi9170 changed the base branch from v2 to develop July 25, 2024 17:55
@paulf81 paulf81 mentioned this pull request Nov 19, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants