Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not ready to merge, just wanted to share the main concept
Feature or improvement description
The pr adds a new file turbine_analysis/detect_yaw_change.py based on approaches suggested by @ejsimley which implements a method for detecting sudden shifts in the northing calibration of yaw angle. The approach is based on cusum change detection one example here. The pr addresses Issue #106
Note this is built on the ruff branch/pr (PR #143 ) so appears to have many more file changes then it actually does. Once that is merged to develop.
Still some way to go on this but main ideas of next steps:
Related issue, if one exists
Closes #106
Impacted areas of the software
turbine_analysis/detect_yaw_change.py