Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sqlalchemy requirement to v2 #160

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Jan 24, 2024

Upgrade sqlalchemy requirement to v2

This pull request addresses Issue #159. Previously there had been some errors when using sqlalchemy v2, but raising the requirement and testing the code for both reading and writing to postgres shows no issue so implementing this pull request to raise the requirement to ~=2.0. The pull request also fixes some small issues in sqldatabase_management.py identified in testing. Since this is a very small change, directly merging (hope that is ok @misi9170 !)

@paulf81 paulf81 merged commit 23e2d7d into NREL:develop Jan 24, 2024
5 of 6 checks passed
@paulf81 paulf81 deleted the sqlalchemy_to_2 branch January 24, 2024 21:02
@misi9170 misi9170 mentioned this pull request Apr 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant