Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to FLASC #172

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Add logging to FLASC #172

merged 11 commits into from
Apr 9, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Feb 12, 2024

Draft for now

Feature or improvement description
This pull request starts the process of converting from print, and the custom function printnow, to using python's logging modules. The code is based on FLORIS' implementation with a central logging_manager.py, however it has been somewhat refactored for FLASC:

  1. Because there isn't a central FLASC object like there is for FLORIS, couldn't rely on external code to call the logging configuration functions with the input yaml instructions like you can with FLORIS, so the configuration is instead done by the LoggingManager class at init based on passed inputs
  2. Based on printnow function, assumed the desired default formatting includes the timestamp

There's not too much left to do, but was curious to see what you think @misi9170 and @Bartdoekemeijer before going to much further. If you want to see what it looks like, example examples_artificial_data/01_raw_data_processing/01_northing_calibration.ipynb has logging outputs in it
Related issue, if one exists
#135

@paulf81 paulf81 added enhancement An improvement of an existing feature v2.0 labels Feb 12, 2024
@paulf81 paulf81 added this to the v2.0 milestone Feb 12, 2024
@paulf81 paulf81 self-assigned this Feb 12, 2024
@Bartdoekemeijer
Copy link
Collaborator

I like this, will definitely streamline and professionalize FLASC!

@paulf81 paulf81 merged commit 969cd7d into NREL:v2 Apr 9, 2024
4 checks passed
@paulf81 paulf81 deleted the feature/add_logging branch April 9, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature v2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants