-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Track FLORIS v4 changes #178
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misi9170
changed the title
[BUGFIX] Track FLORIS v4 change to
[BUGFIX] Track FLORIS v4 changes
Apr 8, 2024
set()
-> run()
paradigm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 870 on FLORIS will release FLORIS v4, which bring significant changes to the FLORIS API that must be mapped over to FLASC. This PR tracks those changes by:
reinitialize()
followed bycalculate_wake()
to one of callingset()
thenrun()
.FlorisInterface
toFlorisModel
, andfi
tofm
, throughout.set()
and starts to usewind_data
objects.Checklist:
Note that this PR does not make a significant effort to utilize new features in FLORIS v4. These will need to be incorporated in a follow-up PR. These changes may include:
fmodel
s and setting model parameters #182fmodel
s and setting model parameters #182