Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Track FLORIS v4 changes #178

Merged
merged 19 commits into from
Apr 8, 2024
Merged

Conversation

misi9170
Copy link
Collaborator

@misi9170 misi9170 commented Mar 5, 2024

PR 870 on FLORIS will release FLORIS v4, which bring significant changes to the FLORIS API that must be mapped over to FLASC. This PR tracks those changes by:

  • reconfiguring the user-level API from a paradigm of calling reinitialize() followed by calculate_wake() to one of calling set() then run().
  • Changing from FlorisInterface to FlorisModel, and fi to fm, throughout.
  • Aligning with new expected usage of set() and starts to use wind_data objects.

Checklist:

  • tests run
  • examples run
  • checks pass

Note that this PR does not make a significant effort to utilize new features in FLORIS v4. These will need to be incorporated in a follow-up PR. These changes may include:

@misi9170 misi9170 marked this pull request as draft March 5, 2024 22:20
@misi9170 misi9170 changed the title [BUGFIX] Track FLORIS v4 change to set() -> run() paradigm [BUGFIX] Track FLORIS v4 changes Apr 8, 2024
@misi9170 misi9170 added the v2.0 label Apr 8, 2024
@misi9170 misi9170 added this to the v2.0 milestone Apr 8, 2024
@misi9170 misi9170 marked this pull request as ready for review April 8, 2024 19:29
@misi9170 misi9170 merged commit f797621 into NREL:v2 Apr 8, 2024
4 checks passed
@misi9170 misi9170 deleted the v2-ms/set-run-paradigm branch April 8, 2024 19:30
@misi9170 misi9170 mentioned this pull request Apr 10, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant