-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add PyPI integration #87
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=======================================
Coverage 40.21% 40.21%
=======================================
Files 40 40
Lines 3971 3971
=======================================
Hits 1597 1597
Misses 2374 2374 ☔ View full report in Codecov by Sentry. |
Looks good @Bartdoekemeijer I will approve and merge, thank you! |
That's great Paul, thanks!! Could you also make the PyPI API token and publish FLASC 1.3 to it? See instructions above. |
hi @Bartdoekemeijer , I gave it a shot today! I made a token and followed all steps, and hit an error on the final one, have you seen this one:
maybe if you add me? I'm using the same username/email on pypi as I use on github |
Wait, I completely missed this... FLASC is already on PyPI?? It seems that Raf did this before going on leave! |
pip install setuptools wheel twine | ||
- name: Build and publish | ||
env: | ||
TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I've added these secrets to the flasc repository
* Merge in changes from `main` branch (v1.3 -> v1.3.1) into `develop`, notably: - Feature: Add PyPI integration by @Bartdoekemeijer in #87 - Bug fix: various small corrections by @Bartdoekemeijer in #86 --------- Co-authored-by: paulf81 <paul.fleming@nrel.gov> Co-authored-by: Rafael M Mudafort <rafael.mudafort@nrel.gov>
Feature or improvement description
Adds PyPI integration so that FLASC becomes pip installable without having to clone the repository from GitHub.
Related issue, if one exists
Issue #49.
Impacted areas of the software
Code deployment.
Additional supporting information
I have followed the style of FLORIS in the
pyproject.toml
andpython-publish.yml
files.Test results, if applicable
See my test deployment on the PyPI testing environment, https://test.pypi.org/project/flasc/1.4/. I bumped this to version 1.4 because I made a mistake when uploading 1.3, and you cannot upload the code for the same version number more than once.
Steps remaining
~/.pypirc
file.