-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add interactive Bokeh plots in ws_pow_filtering #92
Feature: add interactive Bokeh plots in ws_pow_filtering #92
Conversation
I have updated Couple nice features with this Bokeh functionality:
I'm not setting it as the default, but it's easy to enable for the interested user. Last thing to do: |
OK pushed up docstring changes. Ready for review and then merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Bartdoekemeijer, thank you for this! I'm just doing my testing and wanted to just jot down two notes while on front of mind:
- Should we add ipympl to the requirements? I think it is an additional requirement
- Why the == specification for bokeh? Could we not use >=?
Other than that examples work great and I approve the improvement!
Great, thank you @paulf81! I updated the |
This PR is ready to be merged.
Feature or improvement description
This adds interactive browser-based Bokeh plot functionality to the windspeed-power curve filtering class. These figures can easily be saved as .htmls while maintaining their interactive functionality. You can zoom in/out, hide/show data with the legend, resize the plots, etc. This facilitates easy data exploring and additional in-depth analysis post-processing.
Related issue, if one exists
N/A
Impacted areas of the software
ws_pow_filtering
Additional supporting information
N/A
Test results, if applicable
I will share an example soon.