Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

PV Number of Panels #179

Merged
merged 2 commits into from
Dec 10, 2021
Merged

PV Number of Panels #179

merged 2 commits into from
Dec 10, 2021

Conversation

nmerket
Copy link
Member

@nmerket nmerket commented Dec 9, 2021

Fixes #178

Pull Request Description

Allows NumberOfPanels to be used directly from an HPXML (v3) file.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Code changes (must work)
  • Test exercising your feature or bug fix. Check the coverage report in the build artifacts.
  • All other unit tests passing
  • Update translation docs

@nmerket nmerket self-assigned this Dec 9, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

File Coverage
All files 93%
__init__.py 83%
base.py 93%
exceptions.py 96%
hpxml2.py 98%
hpxml3.py 94%

Minimum allowed coverage is 83%

Generated by 🐒 cobertura-action against 2398efc

Copy link
Collaborator

@bpark1327 bpark1327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmerket I have a question for you. Please see below.

hescorehpxml/base.py Show resolved Hide resolved
@bpark1327 bpark1327 self-requested a review December 10, 2021 21:53
Copy link
Collaborator

@bpark1327 bpark1327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@nmerket nmerket merged commit 2a29eea into master Dec 10, 2021
@nmerket nmerket deleted the pv_num_panels branch December 10, 2021 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read NumberOfPanels from PV in HPXML v3
2 participants