Allow building core LK engine without wxWidgets #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjanzou
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, code LK engine doesn't build if wxWidgets is not used (
LK_USE_WXWIDGETSnot defined). This is caused by some wxwidgets related code that doesn't reside inside ifdef/endifLK_USE_WXWIDGETSand missing<<operators forlk_stringtype.This PR fixes this by adding ifdef/endif
LK_USE_WXWIDGETSaround wxWidgets code and implementing<<operators forlk_stringtype whenLK_USE_WXWIDGETSis not defined.