Skip to content

Commit

Permalink
Merge pull request #19 from NREL/develop
Browse files Browse the repository at this point in the history
Release 0.3.0
  • Loading branch information
nllong authored Dec 3, 2020
2 parents 13598d2 + 5ecbb0c commit 4ce435d
Show file tree
Hide file tree
Showing 7 changed files with 47 additions and 23 deletions.
23 changes: 23 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,28 @@
# OpenStudio EE Gem

## Version 0.3.0

* Support for OpenStudio 3.1
* Update OpenStudio Standards to 0.2.12
* Update OpenStudio Extension gem to 0.3.1

## Version 0.2.1

* Update openstudio-extension to 0.2.5
* Adds the following to lib/measures:
* ImproveFanTotalEfficiencyByPercentage
* ReplaceFanTotalEfficiency
* add_apszhp_to_each_zone
* add_energy_recovery_ventilator
* improve_simple_glazing_by_percentage
* reduce_water_use_by_percentage
* replace_hvac_with_gshp_and_doas
* replace_simple_glazing
* set_boiler_thermal_efficiency
* set_water_heater_efficiency_heat_lossand_peak_water_flow_rate
* tenant_star_internal_loads
* vr_fwith_doas

## Version 0.2.0

* Support for OpenStudio 3.0
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def name
end

# define the arguments that the user will input
def arguments
def arguments(model = nil)
args = OpenStudio::Measure::OSArgumentVector.new

return args
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.0</schema_version>
<name>glhe_pro_export_loadsfor_ground_heat_exchanger_sizing</name>
<uid>7bb0ce67-cffb-4ef6-b7fb-093c7c43e263</uid>
<version_id>9e7b6db7-cdf7-46cd-98af-e527072e4431</version_id>
<version_modified>20200423T205217Z</version_modified>
<version_id>ba9023aa-374a-4a78-9c7d-09cbd752e093</version_id>
<version_modified>20200714T172140Z</version_modified>
<xml_checksum>2C8A3EEF</xml_checksum>
<class_name>GLHEProExportLoadsforGroundHeatExchangerSizing</class_name>
<display_name>GLHEProExportLoadsforGroundHeatExchangerSizing</display_name>
Expand Down Expand Up @@ -164,7 +164,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>6358E258</checksum>
<checksum>496F92E3</checksum>
</file>
<file>
<filename>README.md</filename>
Expand All @@ -174,4 +174,3 @@
</file>
</files>
</measure>
<error>wrong number of arguments (given 1, expected 0)</error>
14 changes: 8 additions & 6 deletions lib/measures/nze_hvac/measure.rb
Original file line number Diff line number Diff line change
Expand Up @@ -427,18 +427,20 @@ def run(model, runner, user_arguments)
return false
end

# check that the directory name isn't too long for a sizing run; sometimes this isn't necessary
# if "#{Dir.pwd} }/SizingRun".length > 90
# runner.registerError("Directory path #{Dir.pwd}/SizingRun is greater than 90 characters and too long perform a sizing run.")
# return false
# end

# check that weather file exists for a sizing run
if !model.weatherFile.is_initialized
runner.registerError('Weather file not set. Cannot perform sizing run.')
return false
end

# ensure sizing OA method is aligned
model.getControllerMechanicalVentilations.each do |controller|
controller.setSystemOutdoorAirMethod('ZoneSum')
end

# logic to ensure variable, not cycling, pump operation for chillers
model.getChillerElectricEIRs.each { |chiller| chiller.setChillerFlowMode('LeavingSetpointModulated') }

# log the build messages and errors to a file before sizing run in case of failure
log_messages_to_file("#{Dir.pwd}/openstudio-standards.log", debug = true)

Expand Down
18 changes: 9 additions & 9 deletions lib/measures/nze_hvac/measure.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.0</schema_version>
<name>nze_hvac</name>
<uid>f060dff2-b28d-4194-a6af-e66d88ddb33c</uid>
<version_id>83e77929-f391-407a-8aef-20994f5b7e37</version_id>
<version_modified>20200316T215557Z</version_modified>
<version_id>6d156aab-dd02-41ed-9285-82c07a45707c</version_id>
<version_modified>20201112T192500Z</version_modified>
<xml_checksum>0E5E4776</xml_checksum>
<class_name>NzeHvac</class_name>
<display_name>NZEHVAC</display_name>
Expand Down Expand Up @@ -309,6 +309,12 @@
<usage_type>license</usage_type>
<checksum>E0468DD6</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>1BA0611D</checksum>
</file>
<file>
<version>
<software_program>OpenStudio</software_program>
Expand All @@ -318,13 +324,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>B06BEFD1</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
<filetype>rb</filetype>
<usage_type>test</usage_type>
<checksum>1BA0611D</checksum>
<checksum>CF08F01B</checksum>
</file>
</files>
</measure>
2 changes: 1 addition & 1 deletion lib/openstudio/ee_measures/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@

module OpenStudio
module EeMeasures
VERSION = '0.2.0'.freeze
VERSION = '0.3.0'.freeze
end
end
4 changes: 2 additions & 2 deletions openstudio-ee.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ Gem::Specification.new do |spec|
spec.required_ruby_version = '~> 2.5.0'

spec.add_dependency 'bundler', '~> 2.1'
spec.add_dependency 'openstudio-extension', '~> 0.2.3'
spec.add_dependency 'openstudio-standards', '~> 0.2.11'
spec.add_dependency 'openstudio-extension', '~> 0.3.1'
spec.add_dependency 'openstudio-standards', '~> 0.2.12'

spec.add_development_dependency 'rake', '~> 13.0'
spec.add_development_dependency 'rspec', '~> 3.9'
Expand Down

0 comments on commit 4ce435d

Please sign in to comment.