Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial setup of branch for OpenStudio 3.7.0 #50

Merged
merged 4 commits into from
Dec 14, 2023
Merged

initial setup of branch for OpenStudio 3.7.0 #50

merged 4 commits into from
Dec 14, 2023

Conversation

DavidGoldwasser
Copy link
Collaborator

No description provided.

@DavidGoldwasser DavidGoldwasser marked this pull request as draft October 24, 2023 15:51
@DavidGoldwasser
Copy link
Collaborator Author

DavidGoldwasser commented Oct 24, 2023

@mdahlhausen NzeHvac failed because change of hours in test.

Failure: test_office_radiant_doas(Minitest::Result) [/srv/jenkins/git/openstudio-ee-gem/PR-50/1/lib/measures/nze_hvac/tests/NZEHVAC_Test.rb:193]: For test_office_radiant_doas there were 224.3 unmet occupied heating hours and 2011.2 unmet occupied cooling hours (total: 2235.5), more than the limit of 675.0.

@DavidGoldwasser
Copy link
Collaborator Author

GLHEProExportLoadsforGroundHeatExchangerSizing failed. I'll look into this. That and NzeHVAC were only two

Failure: test_GLHEProExportLoadsforGroundHeatExchangerSizing_good_model(Minitest::Result) [/srv/jenkins/git/openstudio-ee-gem/PR-50/1/lib/measures/GLHEProExportLoadsforGroundHeatExchangerSizing/tests/GLHEProExportLoadsforGroundHeatExchangerSizing_Test.rb:290]: Expected false to be truthy.

…sure

Have to increase min version to 3.7.0 due to changes in E+ Sql out variable names.
should be ready for release
@kflemin kflemin marked this pull request as ready for review December 14, 2023 19:35
@kflemin kflemin merged commit 66988da into develop Dec 14, 2023
1 check passed
@kflemin kflemin deleted the 3.7.0-rc1 branch December 14, 2023 19:35
@DavidGoldwasser DavidGoldwasser restored the 3.7.0-rc1 branch April 25, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants