Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change nze hvac group methods to optional arg #57

Merged
merged 1 commit into from
May 9, 2024
Merged

change nze hvac group methods to optional arg #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/measures/nze_hvac/measure.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ def run(model, runner, user_arguments)
when 'Automatic Partition'
# group zones by occupancy type (residential/nonresidential)
# split non-dominant groups if their total area exceeds 20,000 ft2.
sys_groups = OpenstudioStandards::Geometry.model_group_thermal_zones_by_occupancy_type(model, OpenStudio.convert(20000, 'ft^2', 'm^2').get)
sys_groups = OpenstudioStandards::Geometry.model_group_thermal_zones_by_occupancy_type(model, min_ara_m2: OpenStudio.convert(20000, 'ft^2', 'm^2').get)

# assume secondary system type is PSZ-AC for VAV Reheat otherwise assume same hvac system type
sec_sys_type = hvac_system_type # same as primary system type
Expand Down Expand Up @@ -387,7 +387,7 @@ def run(model, runner, user_arguments)
end

when 'One System Per Building Type'
system_groups = OpenstudioStandards::Geometry.model_group_thermal_zones_by_building_type(model, 0.0)
system_groups = OpenstudioStandards::Geometry.model_group_thermal_zones_by_building_type(model, min_area_m2: 0.0)
system_groups.each do |system_group|
add_system_to_zones(model, runner, hvac_system_type, system_group['zones'], std, doas_dcv: doas_dcv)
end
Expand Down
6 changes: 3 additions & 3 deletions lib/measures/nze_hvac/measure.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
<schema_version>3.1</schema_version>
<name>nze_hvac</name>
<uid>f060dff2-b28d-4194-a6af-e66d88ddb33c</uid>
<version_id>fb498bc9-7394-45d8-a884-9fe5b872176d</version_id>
<version_modified>2024-05-09T17:21:18Z</version_modified>
<version_id>871fe5ea-93e5-4829-ad32-672bfaf0581c</version_id>
<version_modified>2024-05-09T19:08:57Z</version_modified>
<xml_checksum>0E5E4776</xml_checksum>
<class_name>NzeHvac</class_name>
<display_name>NZEHVAC</display_name>
Expand Down Expand Up @@ -258,7 +258,7 @@
<filename>measure.rb</filename>
<filetype>rb</filetype>
<usage_type>script</usage_type>
<checksum>7538C55C</checksum>
<checksum>9C0498C3</checksum>
</file>
<file>
<filename>NZEHVAC_Test.rb</filename>
Expand Down