remove prm model_apply_constructions

duplicate of model_apply_constructions in Standards.Model.rb

Pass the wwr arguments in Standards.Model.rb instead of setting them to nil. If this causes issues, then this needs to be a separate method to set wwr building type.

lib/openstudio-standards/standards/Standards.Model.rb

@@ -7201,9 +7201,12 @@ def model_add_reporting_tolerances(model, heating_tolerance_deg_f: 1.0, cooling_
   # @return [Bool] true if successful, false if not
   # @param model [OpenStudio::Model::Model] OpenStudio model object
   # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
+  # @param [String] wwr_building_type window to wall ratio building type
+  # @param [Hash] hash of extra info for the wwr lookup
   # @return [Bool] returns true if successful, false if not
+  # @todo: wwr inputs may not be necessary, or may be searchable from the model
   def model_apply_constructions(model, climate_zone, wwr_building_type, wwr_info)
-    model_apply_standard_constructions(model, climate_zone, wwr_building_type: nil, wwr_info: {})
+    model_apply_standard_constructions(model, climate_zone, wwr_building_type: wwr_building_type, wwr_info: wwr_info)
 
     return true
   end

lib/openstudio-standards/standards/ashrae_90_1_prm/ashrae_90_1_prm.Model.rb

@@ -1995,18 +1995,6 @@ def get_model_fenestration_area_by_orientation(user_model)
     return fenestration_area_hash
   end
 
-  # Apply the standard construction to each surface in the model, based on the construction type currently assigned.
-  #
-  # @return [Bool] true if successful, false if not
-  # @param model [OpenStudio::Model::Model] OpenStudio model object
-  # @param climate_zone [String] ASHRAE climate zone, e.g. 'ASHRAE 169-2013-4A'
-  # @return [Bool] returns true if successful, false if not
-  def model_apply_constructions(model, climate_zone, wwr_building_type, wwr_info)
-    model_apply_standard_constructions(model, climate_zone, wwr_building_type: wwr_building_type, wwr_info: wwr_info)
-
-    return true
-  end
-
   # Update ground temperature profile based on the weather file specified in the model
   #
   # @param model [OpenStudio::Model::Model] OpenStudio model object