Reorganize prm_test_helper #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weilixu
approved these changes
Nov 30, 2023
|
@weilixu: Thank you; it should be ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
From test/90_1_prm, splits the previous prm_test_helper into 4 files: prm_check, prm_check_helpers, prm_test_model_generator, and prm_test_decorators in order for each file to have their own responsibilities in a test. Methods/keys in test_appengix_g_prm, prm_check, and data/prototype_list.json are organized into alphabetical order.
Pull Request Author
[x] Organizational changes
Review Checklist
[x] CI status: all green or justified - fails develop tests but so does parent branch. Openstudio:3.6.1 test were confirmed to pass by looking in Jenkins despite the current status being pending.