Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to get zipped weather files from the btap_cli weather folder #1643

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

ckirney
Copy link
Collaborator

@ckirney ckirney commented Dec 4, 2023

Pull request overview

  • Fixes #ISSUENUMBERHERE (IF THIS IS A DEFECT)

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

…g btap_cli.rb to support external weather directories containing weather zip files. Adding code to btap_cli_local_test.rb to support this too. Adjusting btap_datapoint.rb to accept, and pass on, external weather data directories. Modifying necb_2011.rb to check if weather files not in the openstudio-standards/data/weather/ directory are contained in a zip file in the external weather data directory. If they are, then the weather zip file is copied to the openstudio-standards/data/weather folder and expanded there. If no appropriate weather data zip files are in the external weather directory (or it doesn't exist) then it moves on to trying to download it from the btap_weather repository.
@ckirney ckirney merged commit a6dfcf6 into nrcan Dec 4, 2023
@ckirney ckirney deleted the nrcan_391 branch December 8, 2023 13:44
@mdahlhausen mdahlhausen changed the title Incorporating ability to add zipped weather files from the btap_cli weather folder. Add method to get zipped weather files from the btap_cli weather folder Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant