Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TableMultiVariableLookup with TableLookup in model_add_curve #1648

Merged

Conversation

JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented Dec 22, 2023

Pull request overview

  • Coming from EUSS cycle 3 upgrade measure work
  • This is related to OS 3.7.0
  • Since it looks like TableMultiVariableLookup class is deprecated in 3.7.0
  • So changing that to TableLookup class
  • It'd be great if I could get a review on this here as well; @mdahlhausen
  • Now that I think of, I guess backward-compatibility should be added rather than my complete replacement
  • I'm testing that modified part with my HP RTU upgrade measure but unsure what would be best for testing for here

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

Copy link
Collaborator

@mdahlhausen mdahlhausen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanghyunJK I made a few changes

  • generalized existing curve lookup
  • added a switch statement to support different OS versions
  • added a test

I'll merge after it runs through the CI

@mdahlhausen mdahlhausen merged commit 9634ee5 into master Jan 21, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the remove-TableMultiVariableLookup-from-model_add_curve branch January 21, 2024 04:17
@mdahlhausen mdahlhausen changed the title replacing TableMultiVariableLookup to TableLookup in model_add_curve Replace TableMultiVariableLookup with TableLookup in model_add_curve Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants