Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PRM lighting log message #1657

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix PRM lighting log message #1657

merged 1 commit into from
Jan 12, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Jan 11, 2024

Pull request overview

Fixes a minor log message
space_type_properties['lighting_space_type'] should be space_type_properties['lpd_space_type']

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • Check rubocop errors
  • Check yard doc errors
  • CI status: all green or justified

space_type_properties['lighting_space_type'] should be space_type_properties['lpd_space_type']
@mdahlhausen mdahlhausen requested a review from weilixu January 11, 2024 16:24
Copy link
Collaborator

@weilixu weilixu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matt for capturing this issue.

@mdahlhausen mdahlhausen merged commit 75dd6f5 into master Jan 12, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/issue1637 branch January 12, 2024 16:06
@mdahlhausen mdahlhausen changed the title Fix minor log message in PRM lighting Fix PRM lighting log message Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lighting space type is missing from the log file
2 participants