Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infiltration module #1695

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Infiltration module #1695

merged 2 commits into from
Feb 28, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Feb 27, 2024

  • replace adjust_infiltration_to_lower_pressure with adjust_infiltration_to_new_pressure
  • move adjust_infiltration_to_prototype_building_conditions
  • move surface_component_infiltration_rate
  • move sub_surface_component_infiltration_rate
  • add tests

Pull request overview

Moves methods into an infiltration module

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes (note at the time of this PR master CI fails; no new tests fail with this PR)

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

- replace adjust_infiltration_to_lower_pressure with adjust_infiltration_to_new_pressure
- move adjust_infiltration_to_prototype_building_conditions
- move surface_component_infiltration_rate
- move sub_surface_component_infiltration_rate
- add tests
@mdahlhausen mdahlhausen requested a review from eringold February 27, 2024 21:53
@mdahlhausen mdahlhausen changed the title add infiltration module Infiltration Module Feb 27, 2024
@mdahlhausen mdahlhausen merged commit 0a2dad5 into master Feb 28, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the refactor/infiltration branch February 28, 2024 18:26
@mdahlhausen mdahlhausen changed the title Infiltration Module Infiltration module Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants