Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor service water heating part 1 #1780

Merged
merged 6 commits into from
Jul 24, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Jul 23, 2024

Pull request overview

This PR begins the process of moving service water heating methods to a dedicated module.
model_add_water_heater is now OpenstudioStandards::ServiceWaterHeating.model_add_water_heater
There are numerous regression test updates because of changes to the syntax in the Water Heater Ambient Temp Schedule name

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • If methods have been deprecated, update rest of code to use the new methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen requested a review from ckirney July 23, 2024 19:26
@mdahlhausen mdahlhausen merged commit 11eec2c into master Jul 24, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the refactor/service_water_heating branch July 24, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant