Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default no ventilation in PTAC and PTHP CBES HVAC #1791

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Aug 15, 2024

Pull request overview

This PR sets PTAC and PTHP units to have no zone ventilation by default in the CBES HVAC constructor.

#1789 fixed a bug (#1753), which now meant the zone hvac ventilation control method is called on all models:

# zone ventilation occupancy control for systems with ventilation
zone_hvac_component_occupancy_ventilation_control(zone_hvac_component)

The default HVAC constructor treats PTAC and PTHP units as having ventilation, which this method then modifies and sets the supply air fan operating schedule to the zone occupancy schedule, rather than "always off" which provides ventilation whenever heating or cooling is active. In practice, most PTAC and PTHP units do not provide ventilation. For buildings that require it, ventilation is usually provided by a DOAS system supplied in corridors with exhaust through bathrooms.
This will not change any of the prototypes, but it will mean ComStock models with PTAC and PTHP systems will no longer have ventilation.

Pull Request Author

  • Method changes or additions
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit ae54d7b into master Aug 15, 2024
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the ptac_pthp_ventilation_default branch August 15, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants