Default no ventilation in PTAC and PTHP CBES HVAC #1791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR sets PTAC and PTHP units to have no zone ventilation by default in the CBES HVAC constructor.
#1789 fixed a bug (#1753), which now meant the zone hvac ventilation control method is called on all models:
The default HVAC constructor treats PTAC and PTHP units as having ventilation, which this method then modifies and sets the supply air fan operating schedule to the zone occupancy schedule, rather than "always off" which provides ventilation whenever heating or cooling is active. In practice, most PTAC and PTHP units do not provide ventilation. For buildings that require it, ventilation is usually provided by a DOAS system supplied in corridors with exhaust through bathrooms.
This will not change any of the prototypes, but it will mean ComStock models with PTAC and PTHP systems will no longer have ventilation.
Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)Review Checklist
This will not be exhaustively relevant to every PR.