Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix symbols in create bar #1793

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Fix symbols in create bar #1793

merged 1 commit into from
Aug 16, 2024

Conversation

mdahlhausen
Copy link
Collaborator

The hash fields need to be cast as symbols, not strings

Pull request overview

Pull Request Author

  • Method changes or additions
  • Added tests for added methods

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

The hash fields need to be cast as symbols, not strings
@mdahlhausen mdahlhausen merged commit 39dd0f5 into master Aug 16, 2024
@mdahlhausen mdahlhausen deleted the fix/geometry_multistory branch August 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant