-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comstock Standards Fixes #1798
Merged
Merged
Comstock Standards Fixes #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although this breaks new rubocop syntax, ruby 2.7 doesn't support the empty keyword argument syntax yet. Once all of stds minimum required version is 3.2, we can revert this commit
- change 'DOAS with VRF' to system_zones and use elec Baseboards for heated only zones - update heating only fuel type to gas unit heaters for 'PTAC with gas coil' and 'PSZ-AC with gas coil' - for PVAV systems, use elec Baseboards for heating only zones -
update boiler properties for DOE ref templates and AEDG templates to match 90.1 schema
update furnace properties for DOE ref templates and AEDG templates to match 90.1 schema
…tudio-standards into comstock_stds_fixes_2
update chiller properties for DOE ref templates and AEDG templates to match 90.1 schema
update heat rejection jsons for DOE ref templates and AEDG templates to match 90.1 schema
update water heater jsons for DOE ref templates and AEDG templates to match 90.1 schema
- add ExteriorWall-Metal Building-Nonresidential properties for all templates and climate zones - add ExteriorRoof-WoodFramed-HighriseResidential for DEER Pre-1975 CEC3
eringold
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
This PR address a number of issues with updating ComStock to use the create typical building workflows in openstudio-standards:
Pull Request Author
bundle exec rake doc
)bundle exec rake rubocop
)Review Checklist