Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comstock Standards Fixes #1798

Merged
merged 18 commits into from
Aug 28, 2024
Merged

Comstock Standards Fixes #1798

merged 18 commits into from
Aug 28, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Aug 27, 2024

Pull request overview

This PR address a number of issues with updating ComStock to use the create typical building workflows in openstudio-standards:

  • reverts rubocop syntax changes for pass-through keyword arguments; these will be changed once openstudio-standards is version limited to Ruby 3+
  • fixes an edge case with minimum resistance in FC factor constructions
  • aligns the CBES HVAC systems in openstudio-standards with their versions in ComStock, particularly for secondary systems.
  • fixes an error with equipment latent, radiant, and lost fractions summing to > 1
  • updates DOE ref efficiency .jsons for boilers, furnaces, chillers, heat rejection, and hot water heaters to match the new PNNL Building Energy Standards Data syntax
  • add missing DEER construction properties for Metal Buildings and Pre-1975 CEC3 roof. The Metal Building exterior wall properties copy the wood-framed values, as is done for the DOE reference buildings.

Pull Request Author

  • Method changes or additions
  • Data changes or additions
  • Added tests for added methods
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

  • [] Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

eringold and others added 18 commits August 24, 2024 21:08
Although this breaks new rubocop syntax, ruby 2.7 doesn't support the empty keyword argument syntax yet.

Once all of stds minimum required version is 3.2, we can revert this commit
- change 'DOAS with VRF' to system_zones and use elec Baseboards for heated only zones
- update heating only fuel type to gas unit heaters for 'PTAC with gas coil' and 'PSZ-AC with gas coil'
- for PVAV systems, use elec Baseboards for heating only zones
-
update boiler properties for DOE ref templates and AEDG templates to match 90.1 schema
update furnace properties for DOE ref templates and AEDG templates to match 90.1 schema
update chiller properties for DOE ref templates and AEDG templates to match 90.1 schema
update heat rejection jsons for DOE ref templates and AEDG templates to match 90.1 schema
update water heater jsons for DOE ref templates and AEDG templates to match 90.1 schema
- add ExteriorWall-Metal Building-Nonresidential properties for all templates and climate zones
- add ExteriorRoof-WoodFramed-HighriseResidential for DEER Pre-1975 CEC3
@mdahlhausen mdahlhausen requested a review from eringold August 27, 2024 18:48
@mdahlhausen mdahlhausen merged commit 5a32d6e into master Aug 28, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the comstock_stds_fixes_2 branch August 28, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants