Fix capacity rounding #1800
Merged
Fix capacity rounding #1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capacity rounding in case of integer may incorrectly return a larger size class if the capacity is near the threshold. Instead, round to the nearest integer and explicitly convert to a float. Fixes issue #1677.
Convert capacity to float instead of rounding to nearest integer, which doesn't work for motor sizing where motor horsepower is typically fractional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
The capacity rounding in case of integer may incorrectly return a larger size class if the capacity is near the threshold. Instead, round to the nearest integer and explicitly convert to a float.
model_find_objectdoes not handle capacity correctly #1677Pull Request Author
Review Checklist
This will not be exhaustively relevant to every PR.