Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods to rename surfaces and subsurfaces #1809

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Sep 16, 2024

Pull request overview

Add space_rename_surfaces_and_subsurfaces(space) and model_rename_surfaces_and_subsurfaces(model) methods rename surfaces and subsurfaces. Call model_rename_surfaces_and_subsurfaces(model) at the end of create bar so surfaces and subsurfaces have non-generic names.

Pull Request Author

  • Method changes or additions
  • Added tests for added methods
  • Documented new methods using yard syntax
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • Check rubocop errors
  • Check yard doc errors
  • If a new feature, test the new feature and try creative ways to break it
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 59aefe0 into master Sep 17, 2024
0 of 2 checks passed
@mdahlhausen mdahlhausen deleted the feature/issue1803 branch September 17, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename surfaces in create bar
2 participants