Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change current directory for CLI #1816

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Change current directory for CLI #1816

merged 1 commit into from
Sep 26, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Sep 25, 2024

Use dir instead of Dir.pwd for running with the CLI

Pull Request Author

  • Method changes or additions
  • All new and existing tests passes
  • If the code adds new require statements, ensure these are in core ruby or add to the gemspec

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

Use __dir__ instead of Dir.pwd for running with the CLI
@ainar
Copy link

ainar commented Sep 26, 2024

I do not get it. There was no issue with the last version of openstudio-standards.
I have got two related issues:

So, what does this PR fix?

@mdahlhausen mdahlhausen merged commit 9fca7da into master Sep 26, 2024
1 of 2 checks passed
@mdahlhausen
Copy link
Collaborator Author

I was able to recreate the issue in openstudio-standards 0.6.3, and it related to using Dir.pwd instead of __dir__ to get the relative location of the bundled weather files regardless of where the script was run from.

You can follow these instructions to use custom gem versions with OpenStudio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use last release of openstudio-standards?
2 participants