Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condenser water loop constructor #1821

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Fix condenser water loop constructor #1821

merged 1 commit into from
Oct 6, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Oct 4, 2024 •
edited
Loading

Pull request overview

Small bug fix to get the optional double from design wetbulb conditions for the condenser loop constructor.

Pull Request Author

  • Method changes or additions
  • Resolved yard documentation errors for new code (ran bundle exec rake doc)
  • Resolved rubocop syntax errors for new code (ran bundle exec rake rubocop)
  • All new and existing tests passes

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • CI status: all green or justified

@mdahlhausen mdahlhausen merged commit 72dabef into master Oct 6, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/condenser_loop_dd_conditions branch October 6, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdahlhausen