Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup for larger DEER motors #1839

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Add lookup for larger DEER motors #1839

merged 1 commit into from
Oct 24, 2024

Conversation

mdahlhausen
Copy link
Collaborator

@mdahlhausen mdahlhausen commented Oct 23, 2024

Pull request overview

The DEER motor efficiency .jsons cap out at 500 hp. Add a lookup for 500 - 9999 hp, similar to the ASHRAE 90.1 motor efficiency .jsons.

Pull Request Author

  • Data changes or additions
  • All new and existing tests passes

Review Checklist

  • Perform a code review on GitHub
  • All related changes have been implemented: method additions, changes, tests
  • CI status: all green or justified

The DEER motor efficiency .jsons cap out at 500 hp. Add a lookup for 500 - 9999 hp, similar to the ASHRAE 90.1 motor efficiency .jsons.
@mdahlhausen mdahlhausen requested a review from eringold October 23, 2024 02:24
@mdahlhausen mdahlhausen merged commit 7b8a377 into master Oct 24, 2024
1 of 2 checks passed
@mdahlhausen mdahlhausen deleted the fix/deer_motor_jsons branch October 24, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant