added latin-1 to decode method line 460 of openfast.py #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix bug in reading of OpenFAST channel names
|
Ryan- One of our longer term goals is to combine all of the OpenFAST python utilities into one authoritative repository. Looking at the openfast_toolbox, it assumes the encoding is ascii, but also catches utf-16. Perhaps we should do the same here and that might also fix your issue? I am skeptical of universally setting the latin1 encoding in the code with this change. |
|
Yeah, that seems ideal. Hopefully that will catch the error I was having. Another potential solution could be a try, except block at the encoding to make it more robust.
Best,
Ryan
…________________________________
From: Garrett Barter ***@***.***>
Sent: Saturday, February 24, 2024 6:51:33 AM
To: NREL/pCrunch ***@***.***>
Cc: Clarke, Ryan James ***@***.***>; Author ***@***.***>
Subject: [EXTERNAL] Re: [NREL/pCrunch] added latin-1 to decode method line 460 of openfast.py (PR #26)
Ryan- One of our longer term goals is to combine all of the OpenFAST python utilities into one authoritative repository. Looking at the openfast_toolbox<https://github.com/OpenFAST/openfast_toolbox>, it assumes the encoding is ascii<https://github.com/OpenFAST/openfast_toolbox/blob/main/openfast_toolbox/io/fast_output_file.py#L238>, but also catches utf-16<https://github.com/OpenFAST/openfast_toolbox/blob/main/openfast_toolbox/io/fast_output_file.py#L261>. Perhaps we should do the same here and that might also fix your issue? I am skeptical of universally setting the latin1 encoding in the code with this change.
—
Reply to this email directly, view it on GitHub<#26 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVW3JD2GPJQRRR4CEMYNU4DYVHV6LAVCNFSM6AAAAABDXHNQ32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGM3DQOJQGE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hi Ryan- Would you mind trying out the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.