Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gb/fix gpool #50

Merged
merged 4 commits into from
May 28, 2024
Merged

Gb/fix gpool #50

merged 4 commits into from
May 28, 2024

Conversation

grantbuster
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.08%. Comparing base (1ce0ef1) to head (b634576).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   88.06%   88.08%   +0.01%     
==========================================
  Files          27       27              
  Lines        3185     3188       +3     
==========================================
+ Hits         2805     2808       +3     
  Misses        380      380              
Flag Coverage Δ
unittests 88.08% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grantbuster grantbuster requested a review from bnb32 May 28, 2024 16:47
@grantbuster
Copy link
Member Author

@bnb32 option to review. The goal here is to implement a pooling layer with a gaussian kernel instead of a uniform average. i flip flopped between a tensorflow conv2d layer (implemented in the previous PR) with fixed kernel versus applying a kernel directly with the tf convolution method. The conv2d layer won't actually work because this needs to operate on each feature independently and a conv2d will apply a uniform kernel to all features and then sum across all features yielding a constant output.

Copy link
Collaborator

@bnb32 bnb32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Were you thinking this might help with sharp edged artifacts?

@grantbuster
Copy link
Member Author

Cool. Were you thinking this might help with sharp edged artifacts?

huh maybe but no i implemented this for the UHI work where we're training simple networks on point observations but want to include some input wide-field spatial information.

@grantbuster grantbuster merged commit 167911d into main May 28, 2024
10 checks passed
@grantbuster grantbuster deleted the gb/fix_gpool branch May 28, 2024 18:52
@bnb32
Copy link
Collaborator

bnb32 commented May 28, 2024

Cool. Were you thinking this might help with sharp edged artifacts?

huh maybe but no i implemented this for the UHI work where we're training simple networks on point observations but want to include some input wide-field spatial information.

ah yeah makes sense.

github-actions bot pushed a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants