-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gb/fix gpool #50
Gb/fix gpool #50
Conversation
…layer because of how feature channels are treated. Reimplemented gpool layer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
==========================================
+ Coverage 88.06% 88.08% +0.01%
==========================================
Files 27 27
Lines 3185 3188 +3
==========================================
+ Hits 2805 2808 +3
Misses 380 380
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@bnb32 option to review. The goal here is to implement a pooling layer with a gaussian kernel instead of a uniform average. i flip flopped between a tensorflow conv2d layer (implemented in the previous PR) with fixed kernel versus applying a kernel directly with the tf convolution method. The conv2d layer won't actually work because this needs to operate on each feature independently and a conv2d will apply a uniform kernel to all features and then sum across all features yielding a constant output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Were you thinking this might help with sharp edged artifacts?
huh maybe but no i implemented this for the UHI work where we're training simple networks on point observations but want to include some input wide-field spatial information. |
ah yeah makes sense. |
No description provided.