Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding rank attr to gaussian noise layer to enable input shape determ… #52

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Sep 6, 2024

…ination for sup3r forward passes

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (3bdbabf) to head (c59f1b9).

Files with missing lines Patch % Lines
phygnn/layers/custom_layers.py 87.50% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.02%     
==========================================
  Files          27       27              
  Lines        3297     3303       +6     
==========================================
+ Hits         2914     2920       +6     
  Misses        383      383              
Flag Coverage Δ
unittests 88.40% <87.50%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…e fly, so that this can be used in forward passes on shapes different than those used in training. Also changed noise to be additive instead of multiplicative
@bnb32 bnb32 merged commit 2499daa into main Sep 12, 2024
10 checks passed
@bnb32 bnb32 deleted the bnb/rank_for_gnoise branch September 12, 2024 22:44
github-actions bot pushed a commit that referenced this pull request Sep 12, 2024
adding rank attr to gaussian noise layer to enable input shape determ…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants