-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support pvlib 0.9.x #290
Support pvlib 0.9.x #290
Conversation
… requirements-min.txt
9765ca5
to
e6acafe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
'pandas==0.23.0', | ||
'pvlib==0.7.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reasoning for removing these? Redundant with requirements.txt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[doc]
is the requirements to build the sphinx docs, which doesn't actually require any rdtools functionality (e.g. make html
does not run the notebooks or tests or anything). So no need to pin specific versions since the packages don't get used for building the docs anyway. And if we're not pinning versions then they're redundant with INSTALL_REQUIRES
.
__init__.py
Extra to-do:
pvlib==0.9.0
is up on pypi as of today. Our current setup.py specifies'pvlib >= 0.7.0, <0.9.0'
, but it'd be nice to support the0.9.x
series if it's easy. I think there are only two relevant changes (but we'll see what the CI has to say):LocalizedPVSystem
is removedtables
dependency is removed andh5py
is added in its place. Note thath5py
is required for pvlib 0.9.0 whereastables
was optional for previous versions.