Degradation

[WilliamsTravis]

This adds the ability to get lifetime outputs, though with restrictions on which variables may be returned. Definitely open to suggestion about how best to handle the limited available lifetime outputs from SAM.

[ppinchuk]

Gunna have to get those tests fixed before we do much more with this I think

[WilliamsTravis]

Hi, yes definitely, got pulled away by a more pressing issue with the runs i need this for, will fix asap.

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (0bf8745) 87.02% compared to head (bc23ad1) 87.09%.

Files	Patch %	Lines
reV/generation/generation.py	92.10%	3 Missing ⚠️
tests/test_gen_pv.py	96.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   87.02%   87.09%   +0.06%     
==========================================
  Files         122      122              
  Lines       17047    17120      +73     
==========================================
+ Hits        14836    14911      +75     
+ Misses       2211     2209       -2     

Flag	Coverage Δ
unittests	87.09% <94.87%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ppinchuk]

Nice job! A few minor requests, with special emphasis on the formatting thorughout.
Huge kudos for doing all the validation checks AND including tests. You're basically a reV developer now :)

[WilliamsTravis]

Now it is failing on docstring lines that are over the line length limit, though these were there before and it had passed. Not sure how you'd like to handle this.

[ppinchuk]

Ooops! Those are totally my bad. Not much to do about it though, since we need that length for the link to work (I'm pretty sure?). Anyways, I disabled the check for those docstrings

[ppinchuk]

Nice job!