Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error handling for h5pyd oserror when hsds server is down/busy #165

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

grantbuster
Copy link
Member

No description provided.

@grantbuster
Copy link
Member Author

Mind blowing that it took me this long to make this error handling. No tests bc don't want to publish api key and i figure it would be really hard to write a function that would reliably trigger this.

ppinchuk
ppinchuk previously approved these changes Sep 12, 2023
Copy link
Collaborator

@ppinchuk ppinchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very minor comment (feel free to ignore), but otherwise simple and clean!

Also hooray for f-strings! Maybe we can start using them more in other places as well :)

rex/resource.py Outdated Show resolved Hide resolved
@ppinchuk
Copy link
Collaborator

Also does this close #161?

Co-authored-by: Paul Pinchuk <ppinchuk@nrel.gov>
@grantbuster grantbuster merged commit 90ffcbd into main Sep 12, 2023
8 checks passed
@grantbuster grantbuster deleted the gb/hsds_error branch September 12, 2023 18:24
github-actions bot pushed a commit that referenced this pull request Sep 12, 2023
added error handling for h5pyd oserror when hsds server is down/busy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants