-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instantiate iterators #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautifully simple solution. Seems like this would have been a pain to track down.
btw does this close #181? If so you could remove the set / intersect logic from |
I don't think so - I didn't actually mess with the dataset name compilation logic |
Instantiate iterators
A lot of the rex
Resource
classes were trying to be their own iterator instances, which can easily cause infinite loops. For example:or for a more verbose option:
This PR forces the iterable
Resource
classes to instead create a unique iterator for every__iter__
invocation, thereby removing the infinite loop issue.