Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssc 1259 scale w pv ac #1260

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

brtietz
Copy link
Collaborator

@brtietz brtietz commented Dec 6, 2024

Add system_capacity_ac outputs to PVSAMV1 and PVWattsV8 to have consistent variables to work with in the hybrids module

Use ac nameplate capacity in the hybrids module for consistency with other models.

Fixes #1259

Can merge into other hybrids branch, or can merge into develop after that one goes first.

@brtietz brtietz added this to the SAM Fall 2024 Release milestone Dec 6, 2024
@brtietz brtietz changed the base branch from develop to ssc_1256_better_hybrid_batteries December 6, 2024 23:19
move var table inputs to dispatch section
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!
I am assuming the failing tests will pass after #1258 is merged - correct?

@janinefreeman janinefreeman removed their request for review December 8, 2024 15:45
@brtietz brtietz merged commit eab94c4 into ssc_1256_better_hybrid_batteries Dec 9, 2024
8 checks passed
@brtietz brtietz deleted the ssc_1259_scale_w_pv_ac branch December 13, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hybrid capacity-based O&M scales with DC PV capacity
5 participants