Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combined conditional moments and wind conditional moments. #207

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

bnb32
Copy link
Collaborator

@bnb32 bnb32 commented Apr 8, 2024

No description provided.

Copy link
Member

@grantbuster grantbuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah we didnt need any of those wind-specific moment batch classes? Is this because of the more general exo data handling you implemented previously? Awesome, love to see that -406 lines count! Less code == easier life.

@bnb32
Copy link
Collaborator Author

bnb32 commented Apr 8, 2024

Woah we didnt need any of those wind-specific moment batch classes? Is this because of the more general exo data handling you implemented previously? Awesome, love to see that -406 lines count! Less code == easier life.

Yeah exactly!

@bnb32 bnb32 merged commit 8c124ae into main Apr 8, 2024
8 checks passed
@bnb32 bnb32 deleted the bnb/cond_mom_simplification branch April 8, 2024 20:15
@bnb32 bnb32 removed the request for review from castelao April 8, 2024 20:15
github-actions bot pushed a commit that referenced this pull request Apr 8, 2024
combined conditional moments and wind conditional moments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants