Gb/presrat updates 2 #230
Gb/presrat updates 2 #230
Conversation
…y from parameters not file
…M to prevent large delta values
… issues with small window size so increased default to 120 (seasonal correction)
… round data to zero anymore
bnb32
force-pushed
the
gb/presrat_updates_2
branch
from
77eab6c
to
8d8474c
Compare
| shape[1], | ||
| rasterizer.shape[2], | ||
| ) | ||
| good_shape = (shape[0], shape[1], rasterizer.shape[2]) |
There was a problem hiding this comment.
haha i dont even remember why i felt the need to fix this but yes trying to have less ugly one liners given the new linting.
sup3r/postprocessing/writers/base.py
Outdated
| @@ -105,6 +105,22 @@ | |||
| 'min': -200, | |||
| 'max': 100, | |||
| }, | |||
| 'temperature_min': { | |||
There was a problem hiding this comment.
we should probably move this dict to its own file, huh?
There was a problem hiding this comment.
Yes could be json just need to make sure the file gets included in pip install like this: https://github.com/NREL/reV/blob/main/setup.py#L87
Want me to do this or have you done it already?
There was a problem hiding this comment.
Haven't done this yet so if you could that'd be awesome.
There was a problem hiding this comment.
Okay done, can you merge when happy?
| sampling='linear', | ||
| log_base=10, | ||
| n_time_steps=24, | ||
| window_size=120, |
There was a problem hiding this comment.
I think this class needs a few more arguments ;)
There was a problem hiding this comment.
Haha too much bloat? Possibly, but for now we just need to be able to modify these from config.
delta_demon_minfrom rex to prevent divide by small numbers in QDM